[pylons-discuss] Small bug in DummySecurityPolicy

[Gerhard Schmidt]

Hi,

I'm doing some tests writing for an project of mine and come to testing
permissions. I use DummySecurityPolicy in most of my tests to speedup
testing. But there is a small problem with the code.

DummySecurityPolicy.principals_allowed_by_permission() returns always
the result of DummySecurityPolicy.effective_principals() regardless if
permissive is True or False.

It should return [] if permissive is set to False.

So the code should look like this.

def principals_allowed_by_permission(self, context, permission):
if self.permissive:
return self.effective_principals(None)
else:
return []

Regards
Estartu

[Steve Piercy]

Please submit an issue or pull request.
https://github.com/Pylons/pyramid/issues/new/choose

--steve

Post by Gerhard Schmidt
I'm doing some tests writing for an project of mine and come to testing
permissions. I use DummySecurityPolicy in most of my tests to speedup
testing. But there is a small problem with the code.
DummySecurityPolicy.principals_allowed_by_permission() returns always
the result of DummySecurityPolicy.effective_principals() regardless if
permissive is True or False.
It should return [] if permissive is set to False.
So the code should look like this.
return self.effective_principals(None)
return []

------------------------
Steve Piercy, Eugene, OR